Skip to content

Allow users to change line endings in the print function #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmaarrfk
Copy link

This relates to an older PR
arduino/Arduino#7364

rewritten for the new code organization

Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One thing to check might be the performance overhead (though I suspect it is minimal, probably just two extra load instructions in most cases).

@hmaarrfk
Copy link
Author

I'm not too sure either.

In my mind, if somebody is really concerned about the performance overhead they would include the \n in their string in the first place. But yeah, you are right, it is worthwhile to consider.

I don't know how to do it though.

facchinm added a commit that referenced this pull request Oct 19, 2018
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@hmaarrfk
Copy link
Author

hmaarrfk commented Apr 9, 2021

i'm not sure why i got a ping for this. I did sign the CLA in case somebody wanted to take a look at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants